Update dataset manager API for data-domain-impacting operations#608
Merged
aaraney merged 7 commits intoNOAA-OWP:masterfrom May 14, 2024
Merged
Conversation
robertbartel
force-pushed
the
f/dataset_domain_autodetect/3/push_domains
branch
4 times, most recently
from
8e8aee9 to
3887d50
Compare
Add functions to support subtracting constraints and data domains.
Only allow for subtracting or merging domains if they have one constraint different (with some caveats for subtraction).
Update dataset manager interface for add_data and delete_data (and implementations) to require a DataDomain for the added/deleted data be passed as an arg so that the dataset's domain can also be updated.
Bumping client to 0.7.0, core to 0.16.0, modeldata to 0.12.0, and dataservice to 0.10.0; also, for each, updating any dependencies on the others to account for the latest version.
robertbartel
force-pushed
the
f/dataset_domain_autodetect/3/push_domains
branch
from
3887d50 to
583215c
Compare
aaraney
reviewed
May 13, 2024
Co-authored-by: Austin Raney <austin.raney@noaa.gov>
Fixing so everything is consistent with new adjusted test data and updates to functionality, in particular requiring a domain be passed to add_data().
aaraney
approved these changes
May 14, 2024
Member
aaraney
left a comment
aaraney
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the changes, @robertbartel!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating DatasetManager and implementations to require a DataDomain parameter being provided when either adding data to or deleting data from an existing dataset. Implementing functions to allow for domain subtraction. Also fixing domain merge function for consistency, so that it only works on one constraint at a time.
Note that this PR depends on #566 and should remain in draft status until that one is merged.